🐛 Destination bigquery denormalize "allOf" and "anyOf" fix #11166

andriikorotkov · 2022-03-15T17:22:06Z

What

Updated JSON schema parsing and allOf and anyOf processing.

How

{"type":"object","properties":{...... "team_ids":{"anyOf":[{"type":"array","items":{"type":"integer"}},{"type":"null"}]},.....},"additionalProperties":false}

🚨 User Impact 🚨

No impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

.../integrations/destination/bigquery/formatter/DefaultBigQueryDenormalizedRecordFormatter.java

…5912_bigquery_denorm_anyof_and_allof

...ava/io/airbyte/integrations/destination/bigquery/util/BigQueryDenormalizedTestDataUtils.java

.../integrations/destination/bigquery/formatter/DefaultBigQueryDenormalizedRecordFormatter.java

…5912_bigquery_denorm_anyof_and_allof

andriikorotkov · 2022-03-25T12:12:26Z

Hi @tuliren. I have corrected all the comments you noticed in this pull request. Please, when you have time, watch this pull request again.

tuliren

Great!

Nitpick. The test cases in BigQueryDenormalizedTestDataUtils.java are moved to JSON files in #11454. It does look cleaner. Could you do the same for the new test cases in this PR for consistency?

…5912_bigquery_denorm_anyof_and_allof

andriikorotkov · 2022-04-05T10:13:47Z

@tuliren Thank you for pointing me to this. I will add these changes

andriikorotkov · 2022-04-05T11:09:45Z

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2095738360
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2095738360
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       168     31    82%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/stream_processor.py                                                                               524    337    36%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1403    520    63%

andriikorotkov · 2022-04-05T15:53:15Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2097300377
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2097300377

andriikorotkov · 2022-04-05T16:06:26Z

/test connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2097374986
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2097374986
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       168     31    82%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/stream_processor.py                                                                               524    337    36%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1403    520    63%

andriikorotkov · 2022-04-05T16:42:48Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2097554841
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/2097554841

* stop covering any array. cover only if we have array of arrays (restriction of BigQuery) * add test with nested arrays and update existing tests * [14058] fix datetime arrays * [11109] cover only array of arrays by object instead of any array * [14058] fix datetime format fail when we have an array of objects with datetime * enable Array and Array+Object DATs * reopen Issue #11166 and disable functionality * Improve the tests by moving common part to Utils * Add tests to check `Array of arrays` cases * Increase version * Doc * format * review update: - update comment about reopen issue - added test case with multiply array sub values - fix nested arrays with datetime - add test case for nested arrays with datetime * fix date formatting * disable testAnyOf test and upd comments * remove some code duplication in the tests * [14668] cover by tests the BigQuery inheritance limitation * Make GCS implementation running same tests as standard impl * Make common format for returning date values to cover DateTime and Timestamp columns by one test * [15363] add backward compatibility for existing connections. * Populate stream config and messages by tablespace. Now it's required inside processing. * Compare only fields from the stream config * Rework BigQueryUploaderFactory and UploaderConfig to have possibility make a decision about array formmater before we create temporary table * Compare fields * remove extra logging * fix project:dataset format of the datasetId * missing import * remove debug logging * fix log messages * format * 4 > 3

…hq#14023) * stop covering any array. cover only if we have array of arrays (restriction of BigQuery) * add test with nested arrays and update existing tests * [14058] fix datetime arrays * [11109] cover only array of arrays by object instead of any array * [14058] fix datetime format fail when we have an array of objects with datetime * enable Array and Array+Object DATs * reopen Issue airbytehq#11166 and disable functionality * Improve the tests by moving common part to Utils * Add tests to check `Array of arrays` cases * Increase version * Doc * format * review update: - update comment about reopen issue - added test case with multiply array sub values - fix nested arrays with datetime - add test case for nested arrays with datetime * fix date formatting * disable testAnyOf test and upd comments * remove some code duplication in the tests * [14668] cover by tests the BigQuery inheritance limitation * Make GCS implementation running same tests as standard impl * Make common format for returning date values to cover DateTime and Timestamp columns by one test * [15363] add backward compatibility for existing connections. * Populate stream config and messages by tablespace. Now it's required inside processing. * Compare only fields from the stream config * Rework BigQueryUploaderFactory and UploaderConfig to have possibility make a decision about array formmater before we create temporary table * Compare fields * remove extra logging * fix project:dataset format of the datasetId * missing import * remove debug logging * fix log messages * format * 4 > 3

fix bug with anyOf and allOf json blocks

bc4beba

andriikorotkov requested review from sashaNeshcheret and VitaliiMaltsev March 15, 2022 17:22

github-actions bot added the area/connectors Connector related issues label Mar 15, 2022

andriikorotkov requested a review from alexandr-shegeda March 15, 2022 17:31

VitaliiMaltsev approved these changes Mar 18, 2022

View reviewed changes

sashaNeshcheret approved these changes Mar 18, 2022

View reviewed changes

.../integrations/destination/bigquery/formatter/DefaultBigQueryDenormalizedRecordFormatter.java Outdated Show resolved Hide resolved

andriikorotkov added 2 commits March 19, 2022 14:54

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

1e7c417

…5912_bigquery_denorm_anyof_and_allof

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

6c64cfc

…5912_bigquery_denorm_anyof_and_allof

andriikorotkov requested a review from tuliren March 21, 2022 15:50

andriikorotkov marked this pull request as ready for review March 21, 2022 15:50

tuliren suggested changes Mar 21, 2022

View reviewed changes

...ava/io/airbyte/integrations/destination/bigquery/util/BigQueryDenormalizedTestDataUtils.java Outdated Show resolved Hide resolved

.../integrations/destination/bigquery/formatter/DefaultBigQueryDenormalizedRecordFormatter.java Outdated Show resolved Hide resolved

andriikorotkov added 4 commits March 22, 2022 10:36

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

85f6b1e

…5912_bigquery_denorm_anyof_and_allof

updated tests and formatter

f6ba9f7

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

b71ccae

…5912_bigquery_denorm_anyof_and_allof

clean code

7d73451

andriikorotkov requested a review from tuliren March 24, 2022 15:58

andriikorotkov requested review from edgao and removed request for edgao April 4, 2022 12:36

tuliren approved these changes Apr 4, 2022

View reviewed changes

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

72fc35b

…5912_bigquery_denorm_anyof_and_allof

updated tests

2c16748

andriikorotkov added 2 commits April 5, 2022 18:05

updated destination_specs yaml file

4a7c85c

updated version of connector and docs

c7ff0bd

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 5, 2022

andriikorotkov temporarily deployed to more-secrets April 5, 2022 15:55 Inactive

andriikorotkov merged commit 72dcd81 into master Apr 5, 2022

andriikorotkov deleted the akorotkov/5912_bigquery_denorm_anyof_and_allof branch April 5, 2022 18:52

DoNotPanicUA added a commit that referenced this pull request Jun 23, 2022

reopen Issue #11166 and disable functionality

43cd999

grishick mentioned this pull request Jun 29, 2022

BigQuery Denormalized : Cover arrays only if they are nested #14023

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination bigquery denormalize "allOf" and "anyOf" fix #11166

🐛 Destination bigquery denormalize "allOf" and "anyOf" fix #11166

andriikorotkov commented Mar 15, 2022 •

edited

Loading

andriikorotkov commented Mar 25, 2022

tuliren left a comment

andriikorotkov commented Apr 5, 2022

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

🐛 Destination bigquery denormalize "allOf" and "anyOf" fix #11166

🐛 Destination bigquery denormalize "allOf" and "anyOf" fix #11166

Conversation

andriikorotkov commented Mar 15, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

andriikorotkov commented Mar 25, 2022

tuliren left a comment

Choose a reason for hiding this comment

andriikorotkov commented Apr 5, 2022

andriikorotkov commented Apr 5, 2022 • edited by github-actions bot Loading

andriikorotkov commented Apr 5, 2022 • edited by github-actions bot Loading

andriikorotkov commented Apr 5, 2022 • edited by github-actions bot Loading

andriikorotkov commented Apr 5, 2022 • edited by github-actions bot Loading

andriikorotkov commented Mar 15, 2022 •

edited

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Apr 5, 2022 •

edited by github-actions bot

Loading