🐛 Destination BigQuery: Handle embedded project ID in dataset ID during normalization #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test connector=bases/base-normalization
|
Comment on lines
134
to
139
| try: | ||
| colon_index = config["dataset_id"].index(":") | ||
| except ValueError: | ||
| colon_index = None | ||
|
|
||
| if colon_index is not None: |
There was a problem hiding this comment.
I freely admit that I don't know Python conventions, so sorry in advance if this code looks terrible :P
No worries! We all have to start somewhere
Maybe it'd be simpler to do in one line:
Suggested change
| try: | |
| colon_index = config["dataset_id"].index(":") | |
| except ValueError: | |
| colon_index = None | |
| if colon_index is not None: | |
| if ":" in config["dataset_id"] |
I guess the convention my instincts are trying to follow here is related to this "rule":
https://docs.python-guide.org/writing/style/#access-a-dictionary-element
There was a problem hiding this comment.
Then, you can follow-up with just using the split string function in python instead of slicing with indices
There was a problem hiding this comment.
thanks! added a check for too many colons just in case it gets mistyped (previously I guess we would have thrown an exception when trying to interact with bigquery)
ChristopheDuong
approved these changes
Mar 14, 2022
|
/publish connector=bases/base-normalization
|
github-actions
bot
added
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Followup to #8383 / #1192
That PR added handling in the destination; we also need to handle this in normalization.
How
When transforming the config, check for this case and mangle the dataset ID value if needed. If the values mismatch, then raise an exception (this is the same behavior as the destination; see https://github.com/airbytehq/airbyte/pull/8383/files#diff-4fd5ae109bf5f80f90ed87bce2642adaca412cce321a84632c1208ccf8ea7ce7R173 )
I freely admit that I don't know Python conventions, so sorry in advance if this code looks terrible :P
Recommended reading order
🚨 User Impact 🚨
No
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit