Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destination-s3: add a test for listObjects permission on destination bucket #10856

Merged
merged 6 commits into from
Mar 11, 2022
Merged

destination-s3: add a test for listObjects permission on destination bucket #10856

merged 6 commits into from
Mar 11, 2022

Commits on Mar 11, 2022

  1. Add a test for listObjects permission to destination-s3 connector 

    * add testIAMUserHasListObjectPermission method to S3Destination
  and call this method from S3Destination::check. Method throws
  an exception if IAM user does not have listObjects permission
  on the destination bucket

* add a unit test to S3DestinationTest to verify that S3Destination::check
  fails if listObjects throws an exception

* add a unit test to S3DestinationTest to verify that S3Destination::check
  succeeds if listObjects succeeds

* Add S3DestinationConfigFactory in order to be able to mock S3 client
  used in S3Destination::check
    grishick committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    f2988ac View commit details
    Browse the repository at this point in the history

  2. Addressing review comments: 

     - separate positive and negative unit tests
 - fix formatting
 - reuse s3 client for both positive and negative tests
    grishick committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    7067ec9 View commit details
    Browse the repository at this point in the history

  3. Add information about PR #10856 to the changelog

    grishick committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2977276 View commit details
    Browse the repository at this point in the history

  4. Prepare for publishing new version: 

     * Bump version to 0.2.10 in Dockerfile
 * Bump version to 0.2.10 in changelog
    grishick committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    8fbc66a View commit details
    Browse the repository at this point in the history

  5. Update destination-s3 version in connector index

    grishick committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    7ea8f7f View commit details
    Browse the repository at this point in the history

  6. Update seed spec for destination-s3 connector

    grishick committed Mar 11, 2022
    1 Configuration menu
    Copy the full SHA
    5444bd2 View commit details
    Browse the repository at this point in the history