Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge old connector definition files #10302

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Feb 13, 2022

Summary

  • Relates to Simplification of version bumping #7668.
  • These individual connector definitions are no longer needed. They are still in the repo for backward compatibility.
  • They are creating lots of confusing for connector contributors.

🚨 User Impact 🚨

@tuliren tuliren temporarily deployed to more-secrets February 13, 2022 04:32 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 13, 2022 04:32 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 13, 2022 04:45 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 13, 2022 04:45 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jrhizor I think we should get rid of these as they still cause confusion for contributors and contractors. WDYT?

@tuliren tuliren requested a review from jrhizor February 14, 2022 19:49
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it. Maybe give heads up to USE in case they get questions?

@tuliren tuliren temporarily deployed to more-secrets February 15, 2022 00:34 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 15, 2022 00:36 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Feb 15, 2022

Will merge after #10331 is merged.

@tuliren tuliren temporarily deployed to more-secrets February 15, 2022 04:21 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 15, 2022 04:21 Inactive
@tuliren tuliren force-pushed the liren/remove-json-connector-definitions branch from aad8203 to 34477fa Compare February 15, 2022 05:26
@tuliren tuliren temporarily deployed to more-secrets February 15, 2022 05:28 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 15, 2022 05:28 Inactive
@tuliren tuliren merged commit ed276f4 into master Feb 15, 2022
@tuliren tuliren deleted the liren/remove-json-connector-definitions branch February 15, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants