Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Marketo - rework read retry #14149

Closed
Tracked by #14056
davydov-d opened this issue Jun 27, 2022 · 6 comments · Fixed by #15683
Closed
Tracked by #14056

Source Marketo - rework read retry #14149

davydov-d opened this issue Jun 27, 2022 · 6 comments · Fixed by #15683

Comments

@davydov-d
Copy link
Collaborator

Issue 9332 demonstrates the connector has a problem creating an async job for further fetching the results. Ideally this should be retried but it is currently impossible cause jobs are created in stream_slices method which is not retriable. So we need to move creating jobs somewhere they can be re-created in case of failure.

As for now the jobs that failed to create are skipped. This can not be a long term solution because it means losing data

@davydov-d
Copy link
Collaborator Author

@YowanR
Copy link
Contributor

YowanR commented Jul 27, 2022

It looks like this item has already been estimated. If the estimate holds, we can move it forward to backlog (Scope).

@davydov-d
Copy link
Collaborator Author

@YowanR I'm going to include this in a certification scope if you're ok with that. Please let me know otherwise

@davydov-d davydov-d self-assigned this Aug 10, 2022
@YowanR
Copy link
Contributor

YowanR commented Aug 10, 2022

@davydov-d Can you clarify what you mean by "include this in a certification scope" ? Thanks!

@davydov-d
Copy link
Collaborator Author

@YowanR I mean implementing this task as a part of the epic

@YowanR
Copy link
Contributor

YowanR commented Aug 10, 2022

Yes, that works for me -- thanks! @davydov-d

davydov-d added a commit that referenced this issue Aug 16, 2022
@davydov-d davydov-d linked a pull request Aug 16, 2022 that will close this issue
davydov-d added a commit that referenced this issue Aug 17, 2022
* #14149 source marketo: retry job creation instead of skipping

* #14149 source marketo: upd changelog

* #14149 source marketo: increase timeouts for SATs

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
rodireich pushed a commit that referenced this issue Aug 25, 2022
* #14149 source marketo: retry job creation instead of skipping

* #14149 source marketo: upd changelog

* #14149 source marketo: increase timeouts for SATs

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants