Skip to content

Commit

Permalink
fixup un-used imports
Browse files Browse the repository at this point in the history
  • Loading branch information
evantahler committed Apr 14, 2022
1 parent 7b3acd6 commit f461ef1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
AirbyteStream,
ConfiguredAirbyteCatalog,
Status,
SyncMode,
Type,
)
from airbyte_cdk.sources import Source
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from airbyte_cdk.models import AirbyteMessage, ConfiguredAirbyteCatalog, Type
from source_faker import SourceFaker


def test_source_streams():
source = SourceFaker()
config = {"count": 1}
Expand Down

1 comment on commit f461ef1

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Source Faker(#11738)

Measures

Name Value Name Value Name Value
Bugs 0 Duplicated Lines (%) 0.0 Lines of Code 71
Coverage 100.0 Code Smells 4 Vulnerabilities 0
Reliability Rating A Duplicated Blocks 0 Lines to Cover 4
Security Rating A Quality Gate Status OK Blocker Issues 0
Critical Issues 0 Major Issues 2 Minor Issues 13

Detected Issues

Rule File Description Message
python:mypy_valid_type (MINOR) source_faker/source.py:28 Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: ...k(self, logger: AirbyteLogger, config: Dict[str, any]) -> AirbyteConne...
python:mypy_valid_type (MINOR) source_faker/source.py:44 Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: ...r(self, logger: AirbyteLogger, config: Dict[str, any]) -> AirbyteCatal...
python:mypy_valid_type (MINOR) source_faker/source.py:71 Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: ... self, logger: AirbyteLogger, config: Dict[str, any], catalog: Config...
python:mypy_valid_type (MINOR) source_faker/source.py:117 Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: def get_stream_cursor(state: Dict[str, any], stream: str) -> int:
python:mypy_index (MINOR) source_faker/source.py Check indexing operations Value of type json? is not indexable . Code line: count: int = config["count"] if "count" in config else 0
python:mypy_attr_defined (MINOR) source_faker/source.py Check that attribute exists json? has no attribute "iter" (not iterable) . Code line: count: int = config["count"] if "count" in config else 0
python:mypy_index (MINOR) source_faker/source.py Check indexing operations Value of type json? is not indexable . Code line: seed: int = config["seed"] if "seed" in config else state["see...
python:mypy_attr_defined (MINOR) source_faker/source.py Check that attribute exists json? has no attribute "iter" (not iterable) . Code line: seed: int = config["seed"] if "seed" in config else state["see...
python:S3358 (MAJOR) source_faker/source.py:94 Conditional expressions should not be nested Extract this nested conditional expression into an independent statement.
python:mypy_valid_type (MINOR) source_faker/source.py Check that type (annotation) is valid Module "json" is not valid as a type . Code line: ... def check(self, logger: AirbyteLogger, config: json) -> AirbyteConne...
python:mypy_valid_type (MINOR) source_faker/source.py Check that type (annotation) is valid Module "json" is not valid as a type . Code line: ...ef discover(self, logger: AirbyteLogger, config: json) -> AirbyteCatal...
python:mypy_valid_type (MINOR) source_faker/source.py Check that type (annotation) is valid Module "json" is not valid as a type . Code line: self, logger: AirbyteLogger, config: json, catalog: Configured...
python:mypy_valid_type (MINOR) source_faker/source.py Check that type (annotation) is valid Function "builtins.any" is not valid as a type . Code line: ...config: json, catalog: ConfiguredAirbyteCatalog, state: Dict[str, any]
flake8:F401 (MAJOR) source_faker/source.py module imported but unused 'airbyte_cdk.models.SyncMode' imported but unused
python:mypy_index (MINOR) source_faker/source.py:118 Check indexing operations Value of type any? is not indexable . Code line: cursor = (state[stream]["cursor"] or 0) if stream in state else 0

Coverage (100.0%)

File Coverage File Coverage
source_faker/init.py 100.0 source_faker/source.py 95.8

Please sign in to comment.