Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): correctly format imagePullSecrets for metrics deployment #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakub-qg
Copy link

@jakub-qg jakub-qg commented Jul 12, 2024

What

Error: YAML parse error on airbyte/charts/metrics/templates/deployment.yaml: error converting YAML to JSON: yaml: line 27: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 27: did not find expected key
YAML parse error on airbyte/charts/metrics/templates/deployment.yaml

Before:

    spec:
      serviceAccountName: airbyte-admin
      imagePullSecrets:
  - name: dockerhub
      nodeSelector:
        dedicated: root-node

After:

    spec:
      serviceAccountName: airbyte-admin
      imagePullSecrets:
        - name: dockerhub # <-- CHANGE HERE
      nodeSelector:
        dedicated: root-node

How

  • fix yaml indentation to allow correct parsing

Can this PR be safely reverted and rolled back?

  • YES 💚

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2024

CLA assistant check
All committers have signed the CLA.

@Udit107710
Copy link

Any update on when this can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants