Fix: Skip latest sqlalchemy version until duckdb_engine fixes bug

[guenp]

Fixes #423

Summary by CodeRabbit

• Chores
  • Updated the version constraint for the sqlalchemy dependency to exclude version 2.0.36, ensuring compatibility with existing features.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request involve an update to the pyproject.toml file, specifically modifying the version constraint for the sqlalchemy dependency. The new constraint explicitly excludes version 2.0.36, while retaining compatibility with versions >=1.4.51 and <3.0. No other significant alterations to dependencies or configuration were made, and the overall structure of the file remains unchanged.

Changes

File	Change Summary
pyproject.toml	Updated sqlalchemy version constraint from ">=1.4.51,<3.0" to ">=1.4.51,!=2.0.36,<3.0"

Assessment against linked issues

Objective	Addressed	Explanation
Address the Catalog Error related to REGCLASS (Issue #423)	❌	The changes do not address the underlying error.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 74ee38e and cf42d81.

📒 Files selected for processing (1)

• pyproject.toml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• pyproject.toml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

pyproject.toml (2)

40-40: Dependency version constraint updated for sqlalchemy. LGTM!

The change from ">=1.4.51,<3.0" to ">=1.4.51,!=2.0.36,<3.0" aligns perfectly with the PR objective of skipping the latest SQLAlchemy version due to the DuckDB engine bug. This should effectively prevent the use of version 2.0.36 while maintaining compatibility with other versions within the specified range.

Quick question though: Have you considered adding a comment explaining why this specific version is excluded? It might help future maintainers understand the reasoning behind this constraint. Something like:

# Exclude SQLAlchemy 2.0.36 due to a DuckDB engine bug (see issue #423)
sqlalchemy = ">=1.4.51,!=2.0.36,<3.0"

What do you think? This could provide valuable context without cluttering the file too much. WDYT?

---

40-40: Consider adding a TODO for future removal

This version constraint is a great temporary fix for the DuckDB engine bug. To ensure we don't forget about it, how about we add a TODO comment or create a follow-up issue to revisit this constraint once the DuckDB engine bug is resolved?

Something like:

# TODO: Remove SQLAlchemy version constraint once DuckDB engine bug is fixed (issue #423)
sqlalchemy = ">=1.4.51,!=2.0.36,<3.0"

Or we could create a GitHub issue to track this. What's your preference? This way, we can ensure this temporary fix doesn't accidentally become permanent. WDYT?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f3bc4c6 and 74ee38e.

📒 Files selected for processing (1)

• pyproject.toml (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

pyproject.toml (2)

40-40: Verify compatibility with related dependencies

The SQLAlchemy version change looks good, but it might be worth double-checking its impact on related dependencies. Particularly, could you confirm that this change doesn't affect the functionality of duckdb, duckdb-engine, snowflake-connector-python, and snowflake-sqlalchemy?

It would be great to run a quick test suite to ensure everything still works as expected with this constraint in place. Have you had a chance to do that yet? If not, would you like some help setting up a test scenario?

---

40-40: Overall, this change looks good and addresses the immediate issue effectively!

To recap:

1. The SQLAlchemy version constraint update aligns with the PR objective.
2. We've suggested adding a comment for context.
3. It's worth verifying compatibility with related dependencies.
4. Consider adding a TODO or creating an issue for future removal of this constraint.

These suggestions aim to improve documentation, ensure stability, and facilitate future maintenance. Let me know if you'd like any clarification or assistance with implementing these suggestions!

[aaronsteers]

/poetry-lock

poetry lock job started... Check job output.

✅ poetry lock applied successfully.