Chore: Rename override constant to TEMP_DIR_OVERRIDE

[aaronsteers]

A follow-on from:

• Feat: Introducing AIRBYTE_TEMP_DIR For Temporary File Mount Overrides #368

Summary by CodeRabbit

• Bug Fixes

  • Renamed the constant for temporary directory overrides to enhance clarity and consistency.

• Chores

  • Updated variable names across multiple files for improved clarity without changing functionality.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve renaming the constant OVERRIDE_TEMP_DIR to TEMP_DIR_OVERRIDE across multiple files, specifically in airbyte/constants.py, airbyte/_executors/util.py, and airbyte/_util/temp_files.py. This modification includes updates to import statements and variable assignments to reflect the new naming convention. The changes aim to enhance clarity without altering the existing functionality or logic of the code.

Changes

Files	Change Summary
airbyte/_executors/util.py, airbyte/_util/temp_files.py, airbyte/constants.py	Renamed OVERRIDE_TEMP_DIR to TEMP_DIR_OVERRIDE. Updated import statements and variable assignments accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant A as airbyte.constants
    participant B as airbyte._executors.util
    participant C as airbyte._util.temp_files

    A->>B: Import TEMP_DIR_OVERRIDE
    A->>C: Import TEMP_DIR_OVERRIDE
    B->>B: Assign TEMP_DIR_OVERRIDE to temp_dir
    C->>C: Use TEMP_DIR_OVERRIDE for temporary files

Loading

What do you think about this summary and the diagram? Any adjustments you’d like to make?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI o1 for code reviews: OpenAI's new o1 model is being tested for code reviews. This model has advanced reasoning capabilities and can provide more detailed feedback on your code.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• • Please join our Discord Community to provide feedback and report issues on the discussion post.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

airbyte/_util/temp_files.py (1)

14-14: Consistency in Import Statements

I noticed that we've updated the constant to TEMP_DIR_OVERRIDE. Should we also ensure that this new name is reflected consistently across all related documentation and comments to avoid any confusion? Wdyt?

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e534a3d and d32fecb.

Files selected for processing (3)

• airbyte/_executors/util.py (2 hunks)
• airbyte/_util/temp_files.py (2 hunks)
• airbyte/constants.py (1 hunks)

Files skipped from review due to trivial changes (2)

• airbyte/_executors/util.py
• airbyte/constants.py

Additional context used

Learnings (1)

airbyte/_util/temp_files.py (1)

Learnt from: niyasrad
PR: airbytehq/PyAirbyte#368
File: airbyte/_util/temp_files.py:26-27
Timestamp: 2024-09-17T18:13:47.331Z
Learning: When `OVERRIDE_TEMP_DIR` is `None`, we should not supply the `dir` argument to `tempfile` functions to preserve the existing behavior.