Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump DuckDB from 0.9 to stable version v1.x #269

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Jun 3, 2024

This should not be a breaking change for existing PyAirbyte users who use DuckDB as a local cache.

For reference on backwards compatibility matters:

Optionally, users may choose to upgrade their existing cache DB files using the method described here:

Note to MotherDuck users:

  1. You will need to use this newer version in order to connect with MotherDuck accounts on post-0.9 versions of DuckDB.
  2. If you have not already done so, you can upgrade your MotherDuck account by navigating to the settings page.
  3. New MotherDuck accounts automatically use the newer (stable) database format, which requires this update.

Manual Testing performed:

  • ✅ Prep: Updated examples/run_faker.py to use a persistent path location (get_default_cache()).
  • ✅ Create a cache in 0.9.x:
    • Switch to main and re-run poetry install. Confirmed that DuckDB was downgraded.
    • Run poetry run python ./examples/run_faker.py. Confirm everything ran correctly.
  • ✅ Write to the cache in 1.x:
    • Switch back to this branch and re-run poetry install. Confirmed that DuckDB was upgraded.
    • Run poetry run python ./examples/run_faker.py. Confirm everything ran correctly.

⚠️ Auto-Merge Enabled ⚠️

@aaronsteers aaronsteers enabled auto-merge (squash) June 3, 2024 18:34
Copy link
Contributor

@bindipankhudi bindipankhudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥳

@aaronsteers aaronsteers merged commit 6210103 into main Jun 3, 2024
18 checks passed
@aaronsteers aaronsteers deleted the aj/chore/bump-duckdb-to-1.0 branch June 3, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants