Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrap is_interactive checks in an exception handler #263

Conversation

rshorser
Copy link
Contributor

Catch exceptions and return False to better support ASGI runtimes

@rshorser rshorser changed the title Wrap is_interactive checks in an exception handler Fix: wrap is_interactive checks in an exception handler May 29, 2024
@rshorser rshorser changed the title Fix: wrap is_interactive checks in an exception handler Fix: Wrap is_interactive checks in an exception handler May 29, 2024
@aaronsteers
Copy link
Contributor

aaronsteers commented May 29, 2024

/test-pr

PR test job started... Check job output.

✅ Tests passed.

@aaronsteers
Copy link
Contributor

aaronsteers commented May 30, 2024

@rshorser - This is great! Thanks for this contribution.

Tests are passing and I'll go ahead and merge now. Expect release to PyPi within 24-48 hours.

cc @bindipankhudi

Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@aaronsteers aaronsteers merged commit 499eeed into airbytehq:main May 30, 2024
8 checks passed
@rshorser rshorser deleted the rshorser-handle-interactive-shell-exception branch May 30, 2024 18:12
@aaronsteers
Copy link
Contributor

aaronsteers commented May 31, 2024

@rshorser - This has released today in 0.11.2. 🚀 Should land in PyPi in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants