Feat: Accept docker image names, move DockerExecutor support to experimental module
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsteers
changed the title
experimental, allow docker_image as str or booldocker_image as str or bool, refactor Docker executor into experimental module
aaronsteers
changed the title
docker_image as str or bool, refactor Docker executor into experimental moduledocker_image as str or bool, refactor DockerExecutor support in get_source to experimental module
aaronsteers
changed the title
docker_image as str or bool, refactor DockerExecutor support in get_source to experimental moduledocker_image as str or bool, move DockerExecutor support to experimental module
aaronsteers
changed the title
docker_image as str or bool, move DockerExecutor support to experimental moduleDockerExecutor support to experimental module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the newly-expanded
get_sourceimplementation into a newairbyte.experimentalmodule, and it reverts the defaultget_sourceimplementation to not support Docker (yet).Also, I've renamed the argument from
docker_executor(bool) todocker_imagewhich can bebool(True) or it can be a string naming the docker image, with an optional tag.