Ensure pybind11 finds the right Python interpreter #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-poveda
previously approved these changes
Dec 4, 2023
g-poveda
dismissed
their stale review
waiting some changes so that the build are not failing
|
It happens to be a wrong configuration on my side. The default behaviour of pybind11 works like a charm whereas the line which this PR adds only make things more complex and it requires more work to actually work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in the recent CMake policies prevents Pybind11 to use the Python interpreter given in scikit-decide's configure args via
-DPYTHON_EXECUTABLE=/path/to/python-interpreter.See pybind11's issue #4785 for more information.
This PR enforces Pybind11 to conform to cmake's CMP0148 policy and to use the python interpreter given to scikit-decide's configuration command line. This is critical since otherwise scikit-decide's build script might not create the wheel for the intended python version.