Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci/cd] Build doc does not work anymore #192

Closed
nhuet opened this issue May 12, 2022 · 1 comment
Closed

[ci/cd] Build doc does not work anymore #192

nhuet opened this issue May 12, 2022 · 1 comment

Comments

@nhuet
Copy link
Contributor

nhuet commented May 12, 2022

🐛 Bug

The "build doc" step from "build scikit-decide" workflow is not working anymore.

To Reproduce

Steps to reproduce the behavior:

  1. Wait for scheduled built
  2. Look for corresponding run

See for instance https://github.com/airbus/scikit-decide/actions/runs/2310818964

Expected behavior

Doc built as before.

Leads

This comes probably from a new version in dependencies.
@nhuet
Copy link
Contributor Author

nhuet commented May 12, 2022

Actually this is due to the installation of preleases even for dependencies (here protobuf 4.12-rc) via

pip install --pre --find-links ./wheels/ scikit-decide[all]

This was necessary so that --find-links option ./wheels/ accept to install the "prerelease" version of scikit-decide downloaded from build step. But it allows also downloading prerelease versions of dependencies.

So a workaround would be to specify explicitely the path to the proper wheel to install. (Using wildcards and specifying only plateform and python version). As in:

pip install wheels/scikit_decide*cp37*manylinux*.whl

nhuet added a commit to nhuet/scikit-decide that referenced this issue May 30, 2022
@nhuet
Avoid installing prereleased dependencies in github action
f4bc742 
The way the scikit-decide library was installed for tests was designed
so that pip find scikit-decide (in prelease mode) in the "wheels" directory.
However a side effect was that it also allowed pip to install preleased
dependencies, which can lead to some bugs, see issue airbus#192.

To avoid this we rather specify explicitely the path to the wheel (but
unsing wildcards to get easily the exact name) and get rid of the
"--pre" option.

We do that in a separate step for better readibility.

Fix airbus#192.
@nhuet nhuet mentioned this issue May 30, 2022
Merged
nhuet added a commit to nhuet/scikit-decide that referenced this issue May 30, 2022
@nhuet
Avoid installing prereleased dependencies in github action
42523c7 
The way the scikit-decide library was installed for tests was designed
so that pip find scikit-decide (in prelease mode) in the "wheels" directory.
However a side effect was that it also allowed pip to install preleased
dependencies, which can lead to some bugs, see issue airbus#192.

To avoid this we rather specify explicitely the path to the wheel (but
unsing wildcards to get easily the exact name) and get rid of the
"--pre" option.

We do that in a separate step for better readibility.

Fix airbus#192.
nhuet added a commit to nhuet/scikit-decide that referenced this issue Jun 2, 2022
@nhuet
Pin protobuf version as it conflicts with ray
7f0e795 
This commit can be revert as soon as
ray-project/ray#25282 is fixed.

Fix issue airbus#192.
@nhuet nhuet mentioned this issue Jun 2, 2022
Merged
nhuet added a commit to nhuet/scikit-decide that referenced this issue Jun 2, 2022
@nhuet
Pin protobuf version as it conflicts with ray
d8dda42 
This commit can be revert as soon as
ray-project/ray#25282 is fixed.

Fix issue airbus#192.
galleon pushed a commit that referenced this issue Jun 3, 2022
@nhuet @galleon
Pin protobuf version as it conflicts with ray
8c3cff4 
This commit can be revert as soon as
ray-project/ray#25282 is fixed.

Fix issue #192.
@galleon galleon closed this as completed in a947139 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhuet