fix(vx-legend): Fix label generation in Threshold legend
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR closes #605 where
@vx/legend'sLegendThresholddoes not generate the correct number of labels after theTSre-write.More context
Without a major refactor, the base
Legendgenerates its labels from thedomainof the inputscale. However forthreshold(andquantile) scales, if thedomaincontainsnthreshold values, therangeshould includen+1values to capture both theless than domain[0]andgreater than domain[1]intervals of the thresholds.The fix
Previously this wasn't accounted for and thus
LegendThresholddid not include the last value in range as seen in the linked issue. This updatesLegendThresholdto instead behave likeLegendQuantileto effectively allow label generation from the range values.This PR also updates the
Legendsdemo to use a valid threshold scale withndomain andn+1range values.Before
After
@hshoff @camille-s @kristw