-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new build] use rollup, add es + umd builds. fixes #143 #298
Conversation
package.json
Outdated
@@ -8,8 +8,7 @@ | |||
"docs": "node ./scripts/docs/index.js", | |||
"prepare-release": "git checkout master && git pull --rebase origin master && npm run docs && lerna updated", | |||
"release": "npm run prepare-release && lerna publish --exact", | |||
"format": "prettier \"{packages,scripts}/**/*.js\" --write", | |||
"precommit": "lint-staged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add this back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing!
Don't know if it applies but you can ignore the commit hooks if you do git commit -m "message" -n
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sto3psl awesome! didn't know I could do that... for context it was only blowing up when i did a commit on windows
this is awesome! 🙌 |
going to merge this and release it as |
fixes: #143
dist/vx-{name}.{umd,es}.js
filesmodule
field topackage.json
that points todist/vx-{name}.es.js
for bundlers that support it (webpack, rollup, etc)main
field points todist/vx-{name}.umd.js
react-fatigue-dev
+ Makefile build (means you can build on windows now)"android": 30, "chrome": 35, "edge": 14, "explorer": 9, "firefox": 52, "safari": 8, "ucandroid": 1
(matching airbnb-babel-presetbuild/
withcjs
babel build files for deep paths (no breaking changes 🤞)