Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new build] use rollup, add es + umd builds. fixes #143 #298

Merged
merged 33 commits into from
Jun 5, 2018
Merged

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Jun 4, 2018

fixes: #143

  • adds dist/vx-{name}.{umd,es}.js files
  • adds module field to package.json that points to dist/vx-{name}.es.js for bundlers that support it (webpack, rollup, etc)
  • main field points to dist/vx-{name}.umd.js
  • removes react-fatigue-dev + Makefile build (means you can build on windows now)
  • build targets "android": 30, "chrome": 35, "edge": 14, "explorer": 9, "firefox": 52, "safari": 8, "ucandroid": 1 (matching airbnb-babel-preset
  • keeps build/ with cjs babel build files for deep paths (no breaking changes 🤞)

package.json Outdated
@@ -8,8 +8,7 @@
"docs": "node ./scripts/docs/index.js",
"prepare-release": "git checkout master && git pull --rebase origin master && npm run docs && lerna updated",
"release": "npm run prepare-release && lerna publish --exact",
"format": "prettier \"{packages,scripts}/**/*.js\" --write",
"precommit": "lint-staged"
Copy link
Member Author

@hshoff hshoff Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: add this back

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing!

Don't know if it applies but you can ignore the commit hooks if you do git commit -m "message" -n.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sto3psl awesome! didn't know I could do that... for context it was only blowing up when i did a commit on windows

@hshoff hshoff changed the title [new build] use rollup, add es + umd builds [new build] use rollup, add es + umd builds. fixes #143 Jun 4, 2018
@hshoff hshoff added this to the v0.0.165 milestone Jun 4, 2018
@williaster
Copy link
Collaborator

this is awesome! 🙌

@hshoff hshoff modified the milestones: v0.0.165, v0.0.165-beta Jun 5, 2018
@hshoff
Copy link
Member Author

hshoff commented Jun 5, 2018

going to merge this and release it as 0.0.165-beta.0 and add beta dist-tag so you can install like @vx/{name}@beta

@hshoff hshoff merged commit d7cd144 into master Jun 5, 2018
@hshoff hshoff deleted the harry-build2 branch June 5, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add module support for tree shaking
3 participants