Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add radial bars demo using Arc #1785

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

adamzuch
Copy link
Contributor

🚀 Enhancements

Added a simple radial bar chart demo to the gallery for #832.

Happy to hear any feedback and make changes if necessary. I tried to follow the other demos in the gallery as a guide.

@williaster
Copy link
Collaborator

This looks great! thanks for the addition, will try to review in the next couple of days (quick glance looks great)

image

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, excited for it to be live (will be once CI finishes on merge). thanks again @adamzuch 🙌

return width < 10 ? null : (
<>
<svg width={width} height={height}>
<GradientLightgreenGreen id="green" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this id is probably okay, on the gallery page with all examples, this should be unique or could potentially conflict (if I see anything can easily fix)

@williaster williaster merged commit 7b3f28a into airbnb:master Jan 11, 2024
2 checks passed
Copy link

🎉 This PR is included in version v3.7.0 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants