fix(axis): include defaultTextProps in Axis labelProps (#1791)

* fix: include defaultTextProps in Axis labelProps This enables passing of partial labelProps per the docs. * Apply suggestions from code review Co-authored-by: Chris Williams <[email protected]> * Update packages/visx-axis/src/axis/AxisRenderer.tsx Co-authored-by: Chris Williams <[email protected]> * Update packages/visx-axis/src/axis/AxisRenderer.tsx Co-authored-by: Chris Williams <[email protected]> --------- Co-authored-by: Chris Williams <[email protected]>
airbnb · Jan 25, 2024 · 843d321 · 843d321
1 parent a185cab
commit 843d321
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/visx-axis/src/axis/AxisRenderer.tsx b/packages/visx-axis/src/axis/AxisRenderer.tsx
@@ -26,7 +26,7 @@ export default function AxisRenderer<Scale extends AxisScale>({
   label = '',
   labelClassName,
   labelOffset = 14,
-  labelProps = defaultTextProps,
+  labelProps,
   orientation = Orientation.bottom,
   scale,
   stroke = '#222',
@@ -42,6 +42,10 @@ export default function AxisRenderer<Scale extends AxisScale>({
   ticks,
   ticksComponent = Ticks,
 }: AxisRendererProps<Scale>) {
+  const combinedLabelProps = {
+    ...defaultTextProps,
+    ...labelProps,
+  };
   const tickLabelPropsDefault = {
     ...defaultTextProps,
     ...(typeof tickLabelProps === 'object' ? tickLabelProps : null),
@@ -89,13 +93,13 @@ export default function AxisRenderer<Scale extends AxisScale>({
           className={cx('visx-axis-label', labelClassName)}
           {...getLabelTransform({
             labelOffset,
-            labelProps,
+            labelProps: combinedLabelProps,
             orientation,
             range: scale.range(),
             tickLabelFontSize: maxTickLabelFontSize,
             tickLength,
           })}
-          {...labelProps}
+          {...combinedLabelProps}
         >
           {label}
         </Text>