Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[cherries] Picking a couple of SQL parsing cherries #140

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

john-bodley
Copy link
Collaborator

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Cherry picking a couple of bug fixes:

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @graceguo-supercat @michellethomas

@john-bodley john-bodley changed the title John bodley cherries [cherries] Picking a couple of SQL parsing cherries Jul 12, 2019
@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #140 into airbnb-master will increase coverage by 0.01%.
The diff coverage is 93.54%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master     #140      +/-   ##
=================================================
+ Coverage          64.97%   64.98%   +0.01%     
=================================================
  Files                427      427              
  Lines              20671    20680       +9     
  Branches            2312     2312              
=================================================
+ Hits               13430    13439       +9     
  Misses              7117     7117              
  Partials             124      124
Impacted Files Coverage Δ
superset/sql_parse.py 99.2% <100%> (+0.06%) ⬆️
superset/security.py 75.86% <60%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ee43a...f1ddfa1. Read the comment docs.

Copy link
Collaborator

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@john-bodley john-bodley merged commit 3db0f00 into airbnb:airbnb-master Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants