This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add sqllab logging and new tab for access requests. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* quote hive column names (apache#5368) * create db migration * use stats_logger timing * trigger build (cherry picked from commit 9a4bba4)
* make access request open new tab * trigger build (cherry picked from commit 01212c3)
timifasubaa
changed the title
john-bodley
approved these changes
Sep 13, 2018
williaster
reviewed
Sep 13, 2018
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| (Request Access) |
There was a problem hiding this comment.
in the UI does this have correct spacing? i.e., is it
my message(Request Access) (bad, no space after message) or
my message (Request Access) (good)
There was a problem hiding this comment.
if not I'd suggest changing the line
(Request Access) to
{' (Request Access)'}
There was a problem hiding this comment.
(I guess this should be done in apache, sorry I missed it there)
There was a problem hiding this comment.
Thanks Chris, I will send out a follow-up PR on open source.
(cherry picked from commit c82cea3)
timifasubaa
force-pushed
the
add_new_sqllab_logging
branch
from
ac727b6 to
0cfc08e
Compare
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
refactor: Migrate word cloud to superset-ui-plugins
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
) Updates the requirements on [fs-extra](https://github.com/jprichardson/node-fs-extra) to permit the latest version. - [Release notes](https://github.com/jprichardson/node-fs-extra/releases) - [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md) - [Commits](https://github.com/jprichardson/node-fs-extra/commits) Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
apache#5862
apache#5859
apache#5844
@airbnb/superset-fork-maintainers