Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tf] fix to address terraform support for cloudtrail event_selector #644

Merged
merged 1 commit into from
Mar 21, 2018
Merged

[tf] fix to address terraform support for cloudtrail event_selector #644

merged 1 commit into from
Mar 21, 2018

Conversation

ryandeivert
Copy link
Contributor

to: @austinbyers
cc: @airbnb/streamalert-maintainers
size: small

Background

The new terraform-provider-aws added support for cloudtrail event_selector. Attempting to apply the streamalert cloudtrail module attempts to overwrite the defaults:

Changes

  • Adding the event_selector to the cloudtrail module to keep the current setting from getting overwritten.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.554% when pulling c216538 on ryandeivert-fix-cloudtrail-tf into 7e96914 on master.

@austinbyers austinbyers merged commit e160a08 into master Mar 21, 2018
@austinbyers austinbyers deleted the ryandeivert-fix-cloudtrail-tf branch March 21, 2018 21:21
@ryandeivert ryandeivert added this to the 2.0.0 milestone Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinbyers austinbyers austinbyers approved these changes

Assignees
No one assigned
Labels
bug terraform
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryandeivert @coveralls @austinbyers