Enable linespacing for versions >= Lollipop (5.0) #13
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zezhouliu
commented
Mar 29, 2017
| @@ -260,7 +278,7 @@ public void setBorderRadius(float borderRadius, int position) { | |||
| } | |||
|
|
|||
| public void setBorderStyle(@Nullable String style) { | |||
| getOrCreateReactViewBackground().setBorderStyle(style); | |||
| getOrCreateReactViewBackground().setBogit rderStyle(style); | |||
zezhouliu
force-pushed
the
al/0.41-linespacing
branch
from
42c8a1e
to
c5da33b
Compare
|
LGTM |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes enables
lineSpacingon Android. It is based on facebook#9420, differing only with respect to minor library import references.This deprecates an older PR: #8
Pictures of changes
Android fonts on Airbnb app
Android fonts specific use cases: