New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_watcher: created a new basic mysql service watcher #26

Open

qasimkhan wants to merge 5 commits into airbnb:master from dubizzle:mysql_watcher

qasimkhan commented Nov 18, 2013

This watcher can be used for load balancing

Qasim Khan added 5 commits

November 17, 2013 22:50


          Merge pull request #3 from airbnb/master

23deb83

Updating master


          mysql_watcher: basic mysql watcher

a625b9b


          mysql_watcher: added mysql dep for rhel

6a28ad8


          mysql_watcher: removed the mysql client dependency

9ba9afd


          mysql_watcher: getting mysql path from bash

2958e87

Collaborator

igor47 commented Feb 6, 2014

some comments:

i'm not a fan of shelling out when the task can easily be accomplished by built-in modules. it introduces an unenforceable dependency that's left to the system operator, and is pretty expensive. plus, the way you're shelling out here would reveal some db credentials on the command line
there are no timeouts enforced here

igor47 mentioned this pull request

pgsql_watcher: created a new basic postgresql service watcher #27

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet