Fix privacy manifest location for SPM #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
approved these changes
Dec 21, 2023
mjburghard
force-pushed
the
fix-privacy-manifest-loc-spm
branch
from
5ae610e
to
c44108f
Compare
Merged
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2252 introduced
PrivacyInfo.xcprivacyin the repositories root directory.While testing the integration of Lottie with SPM, I noticed that the manifest is not included in the app's bundle.
After comparing it with other packages that work, I was able to narrow it down to the location in the repository, or more preciously the
..to point to the parent directory ofSourcesin the copy rule.Moving
PrivacyInfo.xcprivacyintoSourcessolves the issue.