Enable import/no-unresolved and import/export rules #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencioni
force-pushed
the
eslint-plugin-import
branch
from
3ab2ee4 to
a36ddec
Compare
| 'settings': { | ||
| 'import/resolver': { | ||
| 'node': { | ||
| 'extensions': ['.js', '.jsx', '.json'] |
There was a problem hiding this comment.
es6 probably shouldn't include jsx - and actually, probably react should be the file where jsx is added.
lencioni
force-pushed
the
eslint-plugin-import
branch
2 times, most recently
from
4ec5d2c to
e10c1bf
Compare
|
I found a couple more that I think we should enable. Stand by. |
|
Alrighty, this is ready to go. |
| // disallow invalid exports, e.g. multiple defaults | ||
| // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/export.md | ||
| 'import/export': 2, | ||
| // prevents `import * from 'foo';` |
There was a problem hiding this comment.
can we add the rule link to https://github.com/airbnb/javascript#modules--no-wildcard ?
lencioni
force-pushed
the
eslint-plugin-import
branch
from
764a886 to
99a62f8
Compare
These come from eslint-plugin-import. We've been using these rules for a while at Airbnb so it seems like a good time to include them in this configuration. We've found the no-unresolved rule in particular to be very helpful when working across a large codebase. https://github.com/benmosher/eslint-plugin-import Since the no-unresolved rule works on commonjs, I decided to include it in the node configuration as well. I think there are some more rules from this plugin that are worth enabling, but this seems like a great place to start.
lencioni
force-pushed
the
eslint-plugin-import
branch
from
99a62f8 to
0fe4f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These come from eslint-plugin-import. We've been using a couple of these rules for a
while at Airbnb so it seems like a good time to include them in this
configuration. We've found the no-unresolved rule in particular to be
very helpful when working across a large codebase.
https://github.com/benmosher/eslint-plugin-import
Since the no-unresolved rule works on commonjs, I decided to include it
in the node configuration as well.