[react] Including missing defaults to the react eslint #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ module.exports = { | |||
| // Prevent missing displayName in a React component definition | |||
| 'react/display-name': 0, | |||
| // Enforce boolean attributes notation in JSX | |||
| 'react/jsx-boolean-value': 2, | |||
| 'react/jsx-boolean-value': [2, 'never'], | |||
There was a problem hiding this comment.
could we also add in a comment the URL of each of the rules?
There was a problem hiding this comment.
Was literally just about to do that.
There was a problem hiding this comment.
those changes are great but i also meant URLs in comments inline in react.js
There was a problem hiding this comment.
Ah, the classic Double-J communication breakdown.
| 'react/jsx-no-undef': 2, | ||
| // Enforce quote style for JSX attributes | ||
| 'react/jsx-quotes': 0, |
There was a problem hiding this comment.
wow how was this one off‽ thanks
There was a problem hiding this comment.
Ah a fellow interrobanger!
ljharb
added a commit
that referenced
this pull request
Dec 12, 2015
[eslint config] [react] [minor] Including missing defaults to the react eslint; enable react/jsx-quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing including the defaults in a couple react rules for the eslint configuration. This adds them back.