Make the spaces within parenthesis/brackes/curlys rules explicit #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log(foo[0]); | ||
| ``` | ||
|
|
||
| - [18.11](#18.11) <a name='18.11'></a> Add spaces inside curlys. |
There was a problem hiding this comment.
let's call these curly braces to be as clear as possible
|
LGTM pending one comment |
pigoz
force-pushed
the
parens-brackets-curlys
branch
from
cd2f874 to
0931b2e
Compare
pigoz
force-pushed
the
parens-brackets-curlys
branch
from
0931b2e to
6debbcd
Compare
|
Thanks for the feedback! Fixed the problem. |
ljharb
added a commit
that referenced
this pull request
Nov 30, 2015
Make the spaces within parenthesis/brackes/curlys rules explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if something is wrong! The PR spawned from discussions on #593