Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version of eslint-config-airbnb is not compatible with eslint 7.3.0 #2245

Closed
nescalante opened this issue Jun 19, 2020 · 7 comments
Closed

Comments

@nescalante
Copy link

nescalante commented Jun 19, 2020

when using latest version of eslint with latest version of eslint-config-airbnb is throwing the following error:

Oops! Something went wrong! :(

ESLint: 7.3.0

Error: .eslintrc.yml » eslint-config-airbnb » /blablabla/node_modules/eslint-config-airbnb-base/index.js » /blablabla/node_modules/eslint-config-airbnb-base/rules/imports.js:
	Configuration for rule "import/no-cycle" is invalid:
	Value null should be integer.

It seems that when parsing the rule configuration, eslint now receives:

[ 'error', { maxDepth: null, ignoreExternal: false } ]

Removing maxDepth from this line fixes the issue.

@brandly
Copy link

brandly commented Jun 19, 2020

yes! here's a build failing as you describe

@Methuselah96
Copy link

Methuselah96 commented Jun 19, 2020

I wonder if it has to do with the fact that when you JSON stringify Inifinity it becomes null?

@ljharb
Copy link
Collaborator

ljharb commented Jun 19, 2020

Looks like this is due to an eslint bug: eslint/eslint#13427

I'd suggest downgrading to eslint v7.2 for now.

@brandly
Copy link

brandly commented Jun 19, 2020

v7.2 works as expected. thanks!

kuitos added a commit to umijs/qiankun that referenced this issue Jun 20, 2020
SolidZORO added a commit to SolidZORO/leaa that referenced this issue Jun 20, 2020
kjoshi-jisc added a commit to kjoshi-jisc/eslint-prettier-airbnb-react that referenced this issue Jun 22, 2020
Pin eslint to version 7.2.0 to avoid this bug:
airbnb/javascript#2245
Ian-MacLeod added a commit to Ian-MacLeod/portunus-old that referenced this issue Jun 22, 2020
TimeBye pushed a commit to open-hand/choerodon-front-boot that referenced this issue Jun 23, 2020
@j0k3r
Copy link

j0k3r commented Jun 23, 2020

Fixed by ESLint 7.3.1 eslint/eslint#13435

@Knogobert

This comment has been minimized.

@taion
Copy link
Contributor

taion commented Jul 9, 2020

No, they reverted the original config cloning change, not the band-aid hack in v7.3.1. v7.4.0 restores the pre-v7.3.0 behavior, so things should work just fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants