Skip to content

Commit

Permalink
[eslint config] [deps] [breaking] update eslint-config-airbnb-base,…
Browse files Browse the repository at this point in the history 
… `eslint-plugin-import`
  • Loading branch information
@ljharb
ljharb committed Oct 17, 2016
1 parent d7d50bc commit 0bb3eb5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/eslint-config-airbnb/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
},
"homepage": "https://github.com/airbnb/javascript",
"dependencies": {
"eslint-config-airbnb-base": "^8.0.0"
"eslint-config-airbnb-base": "^9.0.0"
},
"devDependencies": {
"babel-preset-airbnb": "^2.1.1",
"babel-tape-runner": "^2.0.1",
"eslint": "^3.8.0",
"eslint-find-rules": "^1.14.0",
"eslint-plugin-import": "^1.16.0",
"eslint-plugin-import": "^2.0.1",
"eslint-plugin-jsx-a11y": "^2.2.3",
"eslint-plugin-react": "^6.4.1",
"in-publish": "^2.0.0",
Expand All @@ -63,7 +63,7 @@
"peerDependencies": {
"eslint": "^3.8.0",
"eslint-plugin-jsx-a11y": "^2.2.3",
"eslint-plugin-import": "^1.16.0",
"eslint-plugin-import": "^2.0.1",
"eslint-plugin-react": "^6.4.1"
},
"engines": {
Expand Down

3 comments on commit 0bb3eb5

@danielkcz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually get this released? It's somewhat strange now since the base depends on 2.0.1 of import plugin, while the main package still relies on 1.16.0.

@ljharb
Copy link
Collaborator Author

@ljharb ljharb commented on 0bb3eb5 Oct 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting on a few things: import-js/eslint-plugin-import#630, so i can bump it in the base config; and then a few bugs in eslint-plugin-react.

I'm not sure why it's strange since people should be depending on either the main config or the base, and should be installing peer deps with the command in the readme, so they shouldn't be running into any problems.

@danielkcz
Copy link

@danielkcz danielkcz commented on 0bb3eb5 Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb Well it's strange in a moment I am working on different projects, one using React (so there is a full airbnb config) and other uses just a base. There are some small differences between those two. But I understand, I will try to survive :) Thanks for a reply.

Please sign in to comment.