Skip to content

Commit

Permalink
[eslint config] [base] [breaking] enable max-classes-per-file
Browse files Browse the repository at this point in the history
  • Loading branch information
@ljharb
ljharb committed Aug 10, 2019
1 parent d03a712 commit 08f8093
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/eslint-config-airbnb-base/rules/best-practices.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ module.exports = {

// enforce a maximum number of classes per file
// https://eslint.org/docs/rules/max-classes-per-file
// TODO: semver-major (eslint 5): enable
'max-classes-per-file': ['off', 1],
'max-classes-per-file': ['error', 1],

// disallow the use of alert, confirm, and prompt
'no-alert': 'warn',
Expand Down

3 comments on commit 08f8093

@SeanOfTheHillPeople
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any mention of this rule in the documentation?

@ljharb
Copy link
Collaborator Author

@ljharb ljharb commented on 08f8093 Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but I see you filed #2143.

@SeanOfTheHillPeople
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being thorough. :) Any explanation you can give would be appreciated.

Please sign in to comment.