CHANGED: The jsdom dependency to allow a range of supported versions. #95
Conversation
| @@ -67,7 +67,7 @@ | |||
| "react": "0.13.x || 0.14.x" | |||
| }, | |||
| "optionalDependencies": { | |||
| "jsdom": "^6.1.0", | |||
| "jsdom": "~3.1.2", | |||
There was a problem hiding this comment.
Please use ^, instead of ~ - older nodes are fine, but older npms don't even work properly with the registry, so there's no reason to support them.
chriscartlidge
force-pushed
the
master
branch
from
8ab8428
to
01d1ef9
Compare
|
@ljharb Sorted. |
ljharb
changed the title
|
So, this will actually prohibit v6, and only work with v3 - what would be ideal is confirming exactly which major version lines of jsdom enzyme works with, and including all of them in the semver range - for example, |
|
@ljharb So it looks like we work against all of the jsdom versions apart from v4. I have updated the semver to take this into consideration. |
chriscartlidge
changed the title
| @@ -67,7 +67,7 @@ | |||
| "react": "0.13.x || 0.14.x" | |||
| }, | |||
| "optionalDependencies": { | |||
| "jsdom": "^6.1.0", | |||
| "jsdom": "^3.1.2 || ^5.6.1 || ^7.2.2", | |||
There was a problem hiding this comment.
could this also include || ^6.1.0 if it works with 6.x? If so, then this won't be a breaking change.
chriscartlidge
force-pushed
the
master
branch
3 times, most recently
from
400df87
to
01d1ef9
Compare
This allows versions of node <= 0.12.0 to use this project as jsdom 4.X > require node 4.X >
|
@ljharb Sorted. |
|
👍 I think this is good to go |
[patch]: Widen jsdom optional dependency to allow a range of supported versions
This allows versions of node <= 0.12.0 to use this project as jsdom 4.X > require node 4.X >
Issue: #94