Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for Node.JS <= v0.12.9 #94

Closed
chriscartlidge opened this issue Dec 29, 2015 · 2 comments
Closed

Allow support for Node.JS <= v0.12.9 #94

chriscartlidge opened this issue Dec 29, 2015 · 2 comments

Comments

@chriscartlidge
Copy link
Contributor

A lot of companies still use older versions of Node.JS for a variety of reasons.

That being said the optional dependancy on jsdom (^6.1.0) requires us to be using Node.JS v4 or greater.

My recommendation is to use jsdom (~3.1.2) which is allow support for a greater number of previous versions of Node.JS.

I have ran through the source code and also check the tests whilst using this version of the jsdom dependency and everything looks OK.

I'll submit a PR and link to this ticket for your consideration. (#95)

@blainekasten
Copy link
Contributor

Looks like this can be closed as the PR is merged.

@ljharb
Copy link
Member

ljharb commented Jan 25, 2016

Closed via #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants