Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Add support for Python 3.10 #48

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

shepting
Copy link
Collaborator

Summary

Cherry-pick change for Python 3.10 support from official Buck main branch.

Cherry-picked from
facebook@1ae1e6c

Original Commit Details

Summary:
Pull Request resolved: facebook#2696

On 3.10 some collections classes have been moved to
collections.abc and it causes Buck 1 to crash. This diff fixes those
instances.

Really pex should be upgraded, but I made an attempt and it was very difficult
due to our custom changes to pex.

Reviewed By: bigfootjon

fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f

Co-authored-by: Lisa Roach [email protected]

Please Review

@qyang-nj @bachand @xianwen

Cherry-picked from
facebook@1ae1e6c

Summary:
Pull Request resolved: facebook#2696

On 3.10 some `collections` classes have been moved to
`collections.abc` and it causes Buck 1 to crash. This diff fixes those
instances.

Really pex should be upgraded, but I made an attempt and it was very difficult
due to our custom changes to pex.

Reviewed By: bigfootjon

fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f

Co-authored-by: Lisa Roach <[email protected]>
Copy link
Collaborator

@qyang-nj qyang-nj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shepting shepting merged commit 02923b2 into airbnb-ios Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants