Bk/optimize view reuse #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynbodayle
approved these changes
Aug 6, 2024
bryankeller
force-pushed
the
bk/optimize-view-reuse
branch
from
7b22260
to
98f5fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This reduced the number of
Setoperations in the ItemViewReuseManager, reducing CPU usage by about 15% (65% -> 50%) when scrolling fast on an iPhone XR.Related Issue
N/A
Motivation and Context
Performance improvement work
How Has This Been Tested
Example app
Types of changes
Checklist