Bk/another accessibility refactor #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
force-pushed
the
bk/another-accessibility-refactor
branch
from
5fdc746
to
a63c3a1
Compare
brynbodayle
reviewed
Jan 26, 2024
| @@ -25,6 +25,7 @@ final class ItemViewReuseManager { | |||
|
|
|||
| func viewsForVisibleItems( | |||
| _ visibleItems: Set<VisibleItem>, | |||
| recycleOldViews: Bool, | |||
There was a problem hiding this comment.
Something more descriptive?
Suggested change
| recycleOldViews: Bool, | |
| recycleOffscreenViews: Bool, |
There was a problem hiding this comment.
Nice, I like that
There was a problem hiding this comment.
They might not be offscreen, so going with recycleUnusedViews (imagine we just switch from using DayViewA to DayViewB for a visible day, it's not really offscreen in terms of being within the visible bounds of the scroll view)
brynbodayle
reviewed
Jan 26, 2024
Sources/Public/CalendarView.swift
Outdated
| @@ -526,6 +520,14 @@ public final class CalendarView: UIView { | |||
| private lazy var scrollViewDelegate = ScrollViewDelegate(calendarView: self) | |||
| private lazy var gestureRecognizerDelegate = GestureRecognizerDelegate(calendarView: self) | |||
|
|
|||
| private var hasHadInitialItemViewFocus = false { | |||
There was a problem hiding this comment.
Suggested change
| private var hasHadInitialItemViewFocus = false { | |
| private var initialItemViewWasFocused = false { |
bryankeller
force-pushed
the
bk/another-accessibility-refactor
branch
13 times, most recently
from
655641b
to
7fbe53d
Compare
bryankeller
force-pushed
the
bk/another-accessibility-refactor
branch
from
7fbe53d
to
1c5e9ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR makes further accessibility improvements. The main thing here is that we no longer post
.layoutChangedor.screenChangednotifications to force focus, and instead rely on UIScrollView to handle maintaining element focus for us (which works well, as long as views aren't reused!).Speaking of that, this disables view recycling when voice over is active. This greatly simplifies things, and removes the need to constantly try to regain control over the focus. I should have thought of this sooner 🫠 We still have flat memory usage since off-screen views are simply deallocated. We pay a small CPU performance price, but Voice Over users won't be scrolling super fast anyways, so the tradeoff seems good. The overall UX for Voice Over users is significantly improved since focus never temporarily jumps around.
Related Issue
N/A
Motivation and Context
Improve VO UX
How Has This Been Tested
Types of changes
Checklist