Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary layout pass #254

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

bryankeller
Copy link
Contributor

Details

Instead of unconditionally marking the layout as dirty, we should just do it if the layout direction changed. This works around an expected behavior of SwiftUI, which might cause it to give new trait collections to views even if nothing has changed.

Related Issue

N/A

Motivation and Context

Internal Airbnb issue

How Has This Been Tested

Example project

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the bug Something isn't working label Aug 4, 2023
brynbodayle
brynbodayle previously approved these changes Aug 4, 2023
@bryankeller bryankeller merged commit 44a79a4 into master Aug 4, 2023
2 checks passed
@bryankeller bryankeller deleted the bk/prevent-unnecessary-layout-pass branch August 4, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants