Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical layout crash for large day ranges #251

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bryankeller
Copy link
Contributor

Details

I introduced a regression when I changed the intrinsic content size strategy here https://github.com/airbnb/HorizonCalendar/pull/250/files#diff-733b4844a228b4fda6b27e4f88b42a6fc4b04eb589081da658741416a2152bd9R1083

Since I started passing in a huge height, it will actually try to layout every single day in the calendar for a huge day range. This caused the Large Day Range demo in the example app to hang at 100% CPU usage, until Springboard killed it 💀

Related Issue

N/A

Motivation and Context

Whoops!

How Has This Been Tested

Example app

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the bug Something isn't working label Aug 2, 2023
@bryankeller bryankeller merged commit 4a064fe into master Aug 2, 2023
2 checks passed
@bryankeller bryankeller deleted the bk/fix-vertical-calendar-crash branch August 2, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants