Fix vertical layout crash for large day ranges #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I introduced a regression when I changed the intrinsic content size strategy here https://github.com/airbnb/HorizonCalendar/pull/250/files#diff-733b4844a228b4fda6b27e4f88b42a6fc4b04eb589081da658741416a2152bd9R1083
Since I started passing in a huge height, it will actually try to layout every single day in the calendar for a huge day range. This caused the Large Day Range demo in the example app to hang at 100% CPU usage, until Springboard killed it 💀
Related Issue
N/A
Motivation and Context
Whoops!
How Has This Been Tested
Example app
Types of changes
Checklist