Set the Via header in proxy requests to origin and in client responses #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dedalusj Hi, could you fix the conflicts? |
|
@cosmtrek Done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
jesses-code-adventures
pushed a commit
to jesses-code-adventures/air
that referenced
this pull request
Sep 25, 2024
air-verse#629) * Set the Via header in proxy requests to origin and in client responses * Remove pseudonym and use host only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the Via HTTP header in requests to origin app and in the client responses.
Applications that uses the oauth workflow require the server to redirect the user back to the callback address. However when running the application behind the air proxy there is no information about which host is the proxy running out. This causes the application to redirect the user to a callback path on the host the application is running at causing a breakdown of the oath flow.
Adding the Via header to the proxy requests allows the applications to detect the proxy host and craft an appropriate callback URL for the oauth flow.