Make include_file overrule include_ext
#358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
changed the title
include_file overrule include_ext
silverwind
force-pushed
the
include_file_ext
branch
from
77a7f87
to
5473afa
Compare
Essentially, a file can now be in `include_file` without having its extension in `include_ext`, which I generally think is the expected behaviour because explicit filenames are more specific than extensions. Fixes: air-verse#350
silverwind
force-pushed
the
include_file_ext
branch
from
25d6480
to
dc1da89
Compare
jamesgoodhouse
approved these changes
Nov 29, 2022
silverwind
commented
Nov 29, 2022
silverwind
commented
Dec 13, 2022
| @@ -251,7 +251,7 @@ func (e *Engine) watchPath(path string) error { | |||
| if excludeRegex { | |||
| break | |||
| } | |||
| if !e.isIncludeExt(ev.Name) { | |||
| if !e.isIncludeExt(ev.Name) && !e.checkIncludeFile(path) { | |||
There was a problem hiding this comment.
I guess the argument here may need to be ev.Name, I will re-verify.
There was a problem hiding this comment.
I guess the argument here may need to be
ev.Name, I will re-verify.
I test the code below, it's ok:
if !e.isIncludeExt(ev.Name) && !e.checkIncludeFile(ev.Name) {
I don't know, why marked this pull request as draft, can i recreate new pull request base on the code?
|
Is there anything problem with this pull request? |
|
I put it on draft because of #358 (comment), but then forgot about the PR. |
|
Your PR does my suggested change so let's move to that one. |
cosmtrek
pushed a commit
that referenced
this pull request
Sep 22, 2024
(#416) * feat: Make include_file overrule include_ext * feat: Make include_file overrule include_ext unittest
jesses-code-adventures
pushed a commit
to jesses-code-adventures/air
that referenced
this pull request
Sep 25, 2024
…ase_on: air-verse#358 (air-verse#416) * feat: Make include_file overrule include_ext * feat: Make include_file overrule include_ext unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A file can now be in
include_filewithout having its extension ininclude_ext, which I generally think is the expected behaviour because explicit filenames are more specific than extensions.Fixes: #350