Proposed change to fix stop_on_error=false not working in .air.toml #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 69.16% 68.82% -0.35%
==========================================
Files 7 7
Lines 960 959 -1
==========================================
- Hits 664 660 -4
- Misses 225 227 +2
- Partials 71 72 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I wouldn't think removal of ONE line ACTUALLY decreases code coverage :) |
KN4CK3R
added a commit
to go-gitea/gitea
that referenced
this pull request
Apr 30, 2023
Current air version runs the old binary if the build fails. This restores the old behaviour. ``` ... code.gitea.io/gitea/services/cron code.gitea.io/gitea/routers/web/user/setting code.gitea.io/gitea/routers/web/org make[2]: *** [Makefile:814: gitea] Error 1 make[2]: Leaving directory '/src' failed to build, error: exit status 2 running... 2023/04/30 21:04:11 cmd/web.go:125:runWeb() [I] Starting Gitea on PID: 29153 2023/04/30 21:04:11 cmd/web.go:178:runWeb() [I] Global init ... ``` Reference: air-verse/air#336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I found a funny bug: I tried to set
stop_on_error = falsein.air.toml, but it had no effect. After some debugging, it turns out that the reason is thismergoissue: darccio/mergo#129The problem is that
stop_on_erroris defined astruein thedefaultConfig()function, butmergowon't overwritetruewithfalsefrom thedefaultPathConfig()function.Other solutions are possible, but this looks the simplest without truly introducing
true/false/undefinedin the concept of air's config for the sake of this one value. Since thestop_on_error = truesnippet is in the example config file since 2020, and actually before that the default was the currentfalse(because the feature was non-existent), I think it would cause a problem for very few people, and make the feature switch-off-able again.Thanks for the great tool, and keep up the good work!
Kristof