feat: Add impersonated service account to gcloud default credentials #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
shinfan
reviewed
Jul 2, 2021
| @@ -147,13 +149,14 @@ digraph d_front_back { | |||
| 1. Use self-signed JWT flow to create an access token locally. | |||
| 1. If certificate is presented, embed the certificate into the JWT. | |||
| 1. Use the regular [self-signed JWT flow][4] for an access token. _[END]_ | |||
| 1. Use user identity flow to exchange for an access token. _[END]_ | |||
| 1. Use the gcloud default credential to exchange for an access token. _[END]_ | |||
There was a problem hiding this comment.
Can you link this flow to 4113? Something like:
Use the gcloud default credential to exchange for an access token. [END]
| target principal to impersonate. All other service accounts are delegates. For | ||
| more information about the ‘--impersonate-service-account’ flag, please read | ||
| the help text of [gcloud][0]. For more information about service account | ||
| impersonation, please read the **TODO(silvano@ will submit his PR)**. |
There was a problem hiding this comment.
Lets remove the TODO here and add this sentence with the impersonation PR.
| applications **should** call [IAM APIs][5] to request a short-lived access | ||
| token of the impersonated service account. The access token of the impersonated | ||
| service account **should** be used to authenticate the request to GCP APIs. | ||
|
|
There was a problem hiding this comment.
Can you add a change log section here?
| @@ -27,8 +33,8 @@ credentials. | |||
|
|
|||
| ### Credentials Generation | |||
|
|
|||
| gcloud default credentials can be generated via command ‘[gcloud auth | |||
| application-default login][2]’. | |||
| gcloud default credentials can be generated via command [gcloud auth | |||
There was a problem hiding this comment.
We can have two sections here:
Gcloud User Credential
...
Impersonated Service Account
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.