Refactoring the public TD management #487
Conversation
|
In the previous setup on boot, we load the blockchain and that involves setting the total difficulty both privately and publically, with these changes what used to be |
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } | ||
| try { |
| if (td == null) { | ||
| // TODO: currently returning incorrect total difficulty | ||
| parseRLP(); | ||
| return new BigInteger(1, this.header.getDifficulty()); |
There was a problem hiding this comment.
This can be confusing (and was confusing before), we only used getCumulativeDifficulty() previously to set difficulty for genesis, and it works out because at genesis cumulativeDiff == diff. Perhaps we should just swap the genesis initialization code to getDifficulty() and return either the cumulative diff (if it is set) or BigInteger.ZERO if it is not.
There was a problem hiding this comment.
Otherwise we may end up in a situation where we retrieve a non-zero difficulty and we cannot be sure whether it is the difficulty or totalDifficulty
|
@yulongaion available to review? |
…getDifficultyBI for initial TD setup
Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):