Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up synchronization in the repository tracker #308

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Cleaning up synchronization in the repository tracker #308

merged 1 commit into from
Mar 29, 2018

Conversation

AlexandraRoatis
Copy link
Contributor

  • added separate locks for changes to accounts and changed to contracts
  • removed synchronization from all methods

qoire
qoire suggested changes Mar 29, 2018
View reviewed changes
modMcf/src/org/aion/mcf/db/AbstractRepositoryCache.java
lockAccounts.writeLock().lock();
lockDetails.writeLock().lock();
try {
getAccountState(address).delete();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression is that this wouldn't work, due to getAccountState() requiring a readLock.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind I am incorrect on this point.

@iamyulong iamyulong merged commit 0883eb6 into dev Mar 29, 2018
@AlexandraRoatis AlexandraRoatis deleted the dev-alexandra branch March 29, 2018 14:52
@AlexandraRoatis AlexandraRoatis mentioned this pull request Mar 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT AionJayT approved these changes

@qoire qoire qoire approved these changes

@iamyulong iamyulong Awaiting requested review from iamyulong

@ali-sharif ali-sharif Awaiting requested review from ali-sharif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandraRoatis @qoire @AionJayT @iamyulong