test_url_query: Expand tests #848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanding URL-query tests to cover more behaviors around special chars when parsing, setting, re-setting and getting values. Bug revealed are marked with `FIXME` to address separately.
Semi-colons are _not_ reserved characters in the query string of a URL; the query string portion consists of `pchar` characters, and `pchar` includes `sub-delim`, which is the class that contains `;`.
- There is no way to distinguish between `?a=` and `?a` when rebuilding a query string. - The further encoding of query delimiters (`=` and `&` in query _values_ is entirely normal and expected.
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 4 4
Lines 768 768
Branches 217 217
=======================================
Hits 766 766
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Turns out this new PR is not needed, as the branch push has been picked up by the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding URL-query tests to cover more behaviors around special chars
when parsing, setting, re-setting and getting values.
Originally created as PR #220.