Preserve non-decodable %-sequences intact when unquote. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 99.72% 99.72% -0.01%
==========================================
Files 4 4
Lines 739 737 -2
Branches 167 165 -2
==========================================
- Hits 737 735 -2
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
serhiy-storchaka
force-pushed
the
unquoting-incremental-decoder
branch
from
e3eb8bb
to
ec902bc
Compare
serhiy-storchaka
force-pushed
the
unquoting-incremental-decoder
branch
from
ec902bc
to
600d5c5
Compare
webknjaz
reviewed
Oct 13, 2020
webknjaz
reviewed
Oct 13, 2020
| @@ -12,7 +12,7 @@ junit_suite_name = yarl_test_suite | |||
|
|
|||
|
|
|||
| [flake8] | |||
| ignore = E301,E302,E704,W503,W504,F811 | |||
| ignore = E203,E301,E302,E704,W503,W504,F811 | |||
There was a problem hiding this comment.
I'd rather inject a few noqas if it's really necessary
There was a problem hiding this comment.
Too many noqas should be injected. blake produces code incompatible with flake8.
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
|
The downside is the loss of performance. After: |
…rchaka/yarl into unquoting-incremental-decoder
|
Fixed the performance regression in Cython: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #517.