Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotation of with_query()/update_query() methods for key=[val1, val2] case #529

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix annotation of with_query()/update_query() methods for key=[val1, val2] case #529

merged 1 commit into from
Oct 12, 2020

Conversation

asvetlov
Copy link
Member

Fixes #528

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           4        4           
  Lines         739      739           
  Branches      168      167    -1     
=======================================
  Hits          737      737           
  Misses          2        2
Impacted Files Coverage Δ
yarl/_quoting_py.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829c932...26ea9d0. Read the comment docs.

@asvetlov asvetlov merged commit 329fc2f into master Oct 12, 2020
@asvetlov asvetlov deleted the fix-annotation branch October 12, 2020 13:47
@nikitagashkov nikitagashkov mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix annotation for with_query()/update_query() methods
1 participant
@asvetlov