Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_url_query: Expand tests #220

Merged
merged 8 commits into from
Apr 19, 2023
Merged

test_url_query: Expand tests #220

merged 8 commits into from
Apr 19, 2023

Commits on Apr 19, 2023

  1. test_url_query: Expand tests 

    Expanding URL-query tests to cover more behaviors around special chars
when parsing, setting, re-setting and getting values.

Bug revealed are marked with `FIXME` to address separately.
    @besfahbod @mjpieters
    besfahbod authored and mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7cb8c8f View commit details
    Browse the repository at this point in the history

  2. Update test_url_query.py

    @behnam @mjpieters
    behnam authored and mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e1245cb View commit details
    Browse the repository at this point in the history

  3. tests: Add type hints to make mypy happy

    @besfahbod @mjpieters
    besfahbod authored and mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    b44ebb8 View commit details
    Browse the repository at this point in the history

  4. test_url_query: Add back assertion for url.query type

    @besfahbod @mjpieters
    besfahbod authored and mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    842002f View commit details
    Browse the repository at this point in the history

  5. Use an annotation for the typehint

    @mjpieters
    mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e6b5325 View commit details
    Browse the repository at this point in the history

  6. Correct semi-colon test 

    Semi-colons are _not_ reserved characters in the query string of a URL;
the query string portion consists of `pchar` characters, and `pchar`
includes `sub-delim`, which is the class that contains `;`.
    @mjpieters
    mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    152bfe1 View commit details
    Browse the repository at this point in the history

  7. Remove non-applicable FIXMEs 

    - There is no way to distinguish between `?a=` and `?a` when rebuilding
  a query string.
- The further encoding of query delimiters (`=` and `&` in query
  _values_ is entirely normal and expected.
    @mjpieters
    mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    f268a30 View commit details
    Browse the repository at this point in the history

  8. Include a changelog entry

    @mjpieters
    mjpieters committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7f12f43 View commit details
    Browse the repository at this point in the history