Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks that bypass the cached property decorators #1445

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 1, 2024

We did not have the ability to write benchmarks that benchmarked the first hit because propcache did not expose the wrapped function until 0.2.1

This will give us a better idea if #1443 is worth it

We did not have the ability to write benchmarks that
benchmarked the first hit because propcache did not
expose the wrapped function until 0.2.1

This will give us a better idea if #1443 is worth it
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Dec 1, 2024
Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #1445 will not alter performance

Comparing benchmark_unwrapped (30d8066) with master (aecebb1)

Summary

✅ 85 untouched benchmarks
🆕 13 new benchmarks

Benchmarks breakdown

Benchmark master benchmark_unwrapped Change
🆕 test_empty_path N/A 52.7 µs N/A
🆕 test_empty_path_safe N/A 52.8 µs N/A
🆕 test_empty_path_safe_uncached N/A 165.9 µs N/A
🆕 test_empty_path_uncached N/A 165.9 µs N/A
🆕 test_empty_query_string_uncached N/A 104.7 µs N/A
🆕 test_empty_raw_path_qs N/A 54.1 µs N/A
🆕 test_empty_raw_path_qs_uncached N/A 113.5 µs N/A
🆕 test_path_safe N/A 55.1 µs N/A
🆕 test_path_safe_uncached N/A 181.1 µs N/A
🆕 test_raw_path_qs N/A 54.4 µs N/A
🆕 test_raw_path_qs_uncached N/A 114 µs N/A
🆕 test_raw_path_qs_with_query N/A 54.5 µs N/A
🆕 test_raw_path_qs_with_query_uncached N/A 145.5 µs N/A

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (aecebb1) to head (30d8066).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
+ Coverage   96.08%   96.13%   +0.04%     
==========================================
  Files          31       31              
  Lines        5882     5948      +66     
  Branches      349      362      +13     
==========================================
+ Hits         5652     5718      +66     
  Misses        204      204              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 96.13% <100.00%> (+0.04%) ⬆️
MyPy 49.85% <89.39%> (+0.46%) ⬆️
OS-Linux 99.56% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.62% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.31% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.29% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.52% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.52% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.29% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.52% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.52% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.25% <100.00%> (+0.01%) ⬆️
Py-3.9.20 99.48% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.53% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.56% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.31% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.56% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.62% <100.00%> (+<0.01%) ⬆️
pytest 99.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review December 1, 2024 18:57
@bdraco bdraco merged commit 7585a96 into master Dec 1, 2024
46 of 48 checks passed
@bdraco bdraco deleted the benchmark_unwrapped branch December 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant