Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move human_quote into the quoters module #1361

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Move human_quote into the quoters module #1361

merged 2 commits into from
Oct 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2024

This is an internal change only

This is an internal change only
This is an internal change only
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #1361 will not alter performance

Comparing human_quote_quoters (aed487c) with master (55967c2)

Summary

✅ 83 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review October 21, 2024 05:35
@bdraco bdraco enabled auto-merge (squash) October 21, 2024 05:35
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (55967c2) to head (aed487c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1361   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          30       30           
  Lines        5608     5610    +2     
  Branches      346      346           
=======================================
+ Hits         5381     5383    +2     
  Misses        201      201           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.95% <100.00%> (+<0.01%) ⬆️
MyPy 45.29% <100.00%> (+0.02%) ⬆️
OS-Linux 99.47% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.53% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.21% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.19% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.19% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.15% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.39% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.44% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.47% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.21% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.47% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.53% <100.00%> (+<0.01%) ⬆️
pytest 99.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 12413d3 into master Oct 21, 2024
42 of 44 checks passed
@bdraco bdraco deleted the human_quote_quoters branch October 21, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant