Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9975/8704bc7 backport][3.11] Add test coverage for accessing StaticResource._routes #9977

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 19, 2024

(cherry picked from commit 8704bc7)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 19, 2024
@bdraco bdraco changed the title Increment version to 3.11.4.dev0 (#9968) Add test coverage for accessing StaticResource._routes Nov 19, 2024
@bdraco bdraco changed the title Add test coverage for accessing StaticResource._routes [PR #9975/8704bc7 backport][3.11] Add test coverage for accessing StaticResource._routes Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (454f914) to head (d79a02c).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #9977      +/-   ##
==========================================
+ Coverage   96.65%   98.02%   +1.37%     
==========================================
  Files         120      122       +2     
  Lines       36805    36888      +83     
  Branches     4415     4440      +25     
==========================================
+ Hits        35573    36161     +588     
+ Misses       1004      544     -460     
+ Partials      228      183      -45     
Flag Coverage Δ
CI-GHA 97.92% <100.00%> (+1.31%) ⬆️
OS-Linux 97.62% <100.00%> (?)
OS-Windows 94.52% <100.00%> (?)
OS-macOS 96.73% <100.00%> (+0.13%) ⬆️
Py-3.10.11 96.59% <100.00%> (+0.28%) ⬆️
Py-3.10.15 97.18% <100.00%> (?)
Py-3.11.10 97.21% <100.00%> (?)
Py-3.11.9 96.66% <100.00%> (+0.27%) ⬆️
Py-3.12.7 97.69% <100.00%> (?)
Py-3.13.0 97.67% <100.00%> (?)
Py-3.9.13 96.52% <100.00%> (?)
Py-3.9.20 97.10% <100.00%> (?)
Py-pypy7.3.16 96.67% <100.00%> (?)
VM-macos 96.73% <100.00%> (+0.13%) ⬆️
VM-ubuntu 97.62% <100.00%> (?)
VM-windows 94.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9977 will improve performances by 25.43%

Comparing patchback/backports/3.11/8704bc74f127497496d4e3241304a6f6d2346494/pr-9975 (d79a02c) with 3.11 (902e7b2)

Summary

⚡ 5 improvements
✅ 38 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/8704bc74f127497496d4e3241304a6f6d2346494/pr-9975 Change
test_simple_web_response 637.2 µs 550 µs +15.86%
test_simple_web_stream_response 392.9 µs 313.2 µs +25.43%
test_web_response_with_bytes_body 727.5 µs 642.1 µs +13.3%
test_web_response_with_headers 1.2 ms 1.1 ms +8.74%
test_web_response_with_text_body 857 µs 772 µs +11.02%

@bdraco bdraco marked this pull request as ready for review November 19, 2024 05:19
@bdraco bdraco enabled auto-merge (squash) November 19, 2024 05:19
@bdraco bdraco merged commit 72935db into 3.11 Nov 19, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/8704bc74f127497496d4e3241304a6f6d2346494/pr-9975 branch November 19, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant